Emergency Reparent Refactor#6449
Merged
deepthi merged 27 commits intovitessio:masterfrom Aug 20, 2020
Merged
Conversation
PrismaPhonic
force-pushed
the
emergency-reparent-refactor
branch
22 times, most recently
from
f84eae3 to
c6c7c9d
Compare
PrismaPhonic
changed the title
PrismaPhonic
force-pushed
the
emergency-reparent-refactor
branch
from
2442c9a to
8caba94
Compare
deepthi
reviewed
Jul 23, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
I recommend running go test -cover. Given the complexity of the design and the number of if conditions, unit test coverage seems thin.
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
…ning tablet in time. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
…ptable number of errors as an argument to accomodate a use case where any number of errors is acceptable. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
…it on handleMaster. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
… on a defer. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
deepthi
reviewed
Aug 5, 2020
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
…o apply before running competition. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
PrismaPhonic
force-pushed
the
emergency-reparent-refactor
branch
from
757fc34 to
fff559f
Compare
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
deepthi
previously requested changes
Aug 20, 2020
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Looking good except for the few pending comments/changes
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR executes on all aspects of the
EmergencyReparentre-design. Fixes #6206